Suppress warning on exit by properly closing pydevd socket#1826
Merged
rchiodo merged 2 commits intomicrosoft:mainfrom Feb 5, 2025
bersbersbers:main
Merged
Suppress warning on exit by properly closing pydevd socket#1826rchiodo merged 2 commits intomicrosoft:mainfrom bersbersbers:main
pydevd socket#1826rchiodo merged 2 commits intomicrosoft:mainfrom
bersbersbers:main
Conversation
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
That's kinda strange, but we do try to keep pydev.debugger and debugpy in sync. So theoretically a push here will end up in Pydev.debugger eventually. |
Contributor
Author
|
It's less strange once you consider that I started looking into pydevd only to fix this one bug. I have no idea how to even connect anything to pydevd, apart from debugpy. So I should probably rephrase, I don't know how I can reproduce it in pydevd, but that should not mean that I believe there is no way at all. |
rchiodo
approved these changes
Feb 5, 2025
Contributor
|
Thanks for the submission. Should ship in our next release. |
This was referenced Apr 25, 2025
Contributor
Author
|
Backport in fabioz/PyDev.Debugger#304 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1812.
I am unsure if I should submit this to https://github.com/fabioz/PyDev.Debugger (first) because I can reproduce this only in conjunction with
debugpy, like so: